genegr commented on PR #13061: URL: https://github.com/apache/cloudstack/pull/13061#issuecomment-4700228395
Thanks @slavkap — great catch. The interface drift was real: between the last rebase of this branch (05-22) and main today, `KVMStoragePool` had two method renames: - `checkingHeartBeat(HAStoragePool, HostTO)` → `hasHeartBeat(HAStoragePool, HostTO)` - `vmActivityCheck(...)` → `hasVmActivity(...)` (same signature) Rebased the branch onto current `upstream/main` and pushed `93eb9d94e1 kvm: align MultipathNVMeOFPool with KVMStoragePool API change`, which renames the two `@Override` methods on `MultipathNVMeOFPool` to match (mirrors how `MultipathSCSIPool` implements them). Both still return `null` since `MultipathNVMeOFPool` doesn't participate in KVM-side HA heartbeat. Verified locally with `mvn -pl plugins/hypervisors/kvm -am -DskipTests compile`. Should be clean for you on the next pull — happy to repackage if useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
