winterhazel commented on PR #12124: URL: https://github.com/apache/cloudstack/pull/12124#issuecomment-4731162052
> Hello @winterhazel @DaanHoogland @Pearl1594 > > The test result looks good. > > > [SF] Trillian test result (tid-16299) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 49044 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12124-t16299-kvm-ol8.zip Smoke tests completed. 151 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: > > Test Result Time (s) Test File > > i am not sure how to resolve these two :/ <img alt="image" width="908" height="144" src="https://private-user-images.githubusercontent.com/96632094/608368571-6d20cac9-4076-4424-b27c-c7acb80081a0.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODE3MDI0NjMsIm5iZiI6MTc4MTcwMjE2MywicGF0aCI6Ii85NjYzMjA5NC82MDgzNjg1NzEtNmQyMGNhYzktNDA3Ni00NDI0LWIyN2MtYzdhY2I4MDA4MWEwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjA2MTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwNjE3VDEzMTYwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTIyNjc5MmQ2OTcyZjZlMGQyYTcwNmNhYWZjYWZhMzljZmM2Mzk5OTZkZGJkZjMwNmY2MjNlNTdiNjBkODcxZjAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.9cy436sK7OCq-DwM3-uH4ZmBOCWHVHdfjyCzL11JDGs";> @mhkadhum the first failure is caused by the lack of unit tests (coverage under 18%) for these changes. Passing this check is not a requirement for merging, but of course it would be good to have tests to prevent future regressions, if you would like to add some. The second one does not seem related to your changes, but I triggered a rerun. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://private-user-images.githubusercontent.com/96632094/608368571-6d20cac9-4076-4424-b27c-c7acb80081a0.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODE3MDI0NjMsIm5iZiI6MTc4MTcwMjE2MywicGF0aCI6Ii85NjYzMjA5NC82MDgzNjg1NzEtNmQyMGNhYzktNDA3Ni00NDI0LWIyN2MtYzdhY2I4MDA4MWEwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjA2MTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwNjE3VDEzMTYwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTIyNjc5MmQ2OTcyZjZlMGQyYTcwNmNhYWZjYWZhMzljZmM2Mzk5OTZkZGJkZjMwNmY2MjNlNTdiNjBkODcxZjAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.9cy436sK7OCq-DwM3-uH4ZmBOCWHVHdfjyCzL11JDGs"](https://private-user-images.githubusercontent.com/96632094/608368571-6d20cac9-4076-4424-b27c-c7acb80081a0.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODE3MDI0NjMsIm5iZiI6MTc4MTcwMjE2MywicGF0aCI6Ii85NjYzMjA5NC82MDgzNjg1NzEtNmQyMGNhYzktNDA3Ni00NDI0LWIyN2MtYzdhY2I4MDA4MWEwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjA2MTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwNjE3VDEzMTYwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTIyNjc5MmQ2OTcyZjZlMGQyYTcwNmNhYWZjYWZhMzljZmM2Mzk5OTZkZGJkZjMwNmY2MjNlNTdiNjBkODcxZjAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.9cy436sK7OCq-DwM3-uH4ZmBOCWHVHdfjyCzL11JDGs"){kind=link}