jmsperu commented on PR #12843: URL: https://github.com/apache/cloudstack/pull/12843#issuecomment-4762925490
Thanks @DaanHoogland / Copilot. Pushed `d64286b` addressing the open points: - **`Failed` job didn't break the wait loop**: now exits after `cleanup` instead of spinning until `BACKUP_TIMEOUT`. - **`backup_stopped_vm` `qemu-img` failure**: exits after `cleanup` (no partial-treated-as-success) and appends to the agent log instead of truncating it. - **`mount | tee` under `set -eo pipefail`**: `mount`'s own exit is tested in an `if`, so a mount failure is reported instead of being masked by `tee` / aborting before the check. - **`cleanup` umount**: only unmounts when the path is actually a mount, so a non-mount umount no longer reports `EXIT_CLEANUP_FAILED` via the EXIT trap. While testing this I also found that `backup_stopped_vm` didn't unmount on success — so `trap cleanup EXIT` ran `rm -rf "$dest"` and deleted the just-completed backup. It now unmounts on success like `backup_running_vm`/`delete_backup`. Verified with a stubbed self-test: a successful backup persists, and a failed convert exits non-zero with the partial cleaned up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
