Damans227 commented on code in PR #12843:
URL: https://github.com/apache/cloudstack/pull/12843#discussion_r3624821640
##########
scripts/vm/hypervisor/kvm/nasbackup.sh:
##########
@@ -253,28 +285,77 @@ mount_operation() {
if [ ${NAS_TYPE} == "cifs" ]; then
MOUNT_OPTS="${MOUNT_OPTS},nobrl"
fi
- mount -t ${NAS_TYPE} ${NAS_ADDRESS} ${mount_point} $([[ ! -z "${MOUNT_OPTS}"
]] && echo -o ${MOUNT_OPTS}) 2>&1 | tee -a "$logFile"
- if [ $? -eq 0 ]; then
+ # Test mount's own exit in an if-condition: under `set -eo pipefail` the
previous
Review Comment:
Nit: this comment is quite long for an inline explanation, could trim to a
line or two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
