abh1sar opened a new pull request, #13537:
URL: https://github.com/apache/cloudstack/pull/13537
### Description
`LibvirtStorageAdapter` used to identify the poolType for a Shared mount
point storage as `StoragePoolType.Filesystem` as it derived it from LIbvirt's
XML where both Local Storage and SMP map to the `PoolType.Dir`.
So it used to have the same behaviour as Local Storage and NFS as their are
some conditions that only check these two storages:
```
if (StoragePoolType.NetworkFilesystem.equals(poolType) ||
StoragePoolType.Filesystem.equals(poolType)) {
```
https://github.com/apache/cloudstack/pull/12773 (4.22.1) changed this to set
the poolType as `SharedMountPoint`. It causes Shared Mount Point to be excluded
from a few places in code.
This creates a few problems:
1. Encryption not being applied to the volumes .
2. Qcow2 being created with `compat=0.10` or version2 instead of 3.
This is because disk creation is now being done using
**`createPhysicalDiskByLibVirt`** instead of **`createPhysicalDiskByQemuImg`**
3. Migrating a VM from NFS to SMP storage fails
This is because createDiskFromTemplateBacking returns now for SMP
```
public KVMPhysicalDisk createDiskFromTemplateBacking(KVMPhysicalDisk
template, String name, PhysicalDiskFormat format, long size,
KVMStoragePool
destPool, int timeout, byte[] passphrase) {
String volumeDesc = String.format("volume [%s], with template
backing [%s], in pool [%s] (%s), with size [%s] and encryption is %s", name,
template.getName(), destPool.getUuid(),
destPool.getType(), size, passphrase != null && passphrase.length
> 0);
if
(!poolTypesThatEnableCreateDiskFromTemplateBacking.contains(destPool.getType()))
{
logger.info(String.format("Skipping creation of %s due to pool
type is none of the following types %s.", volumeDesc,
poolTypesThatEnableCreateDiskFromTemplateBacking.stream()
.map(type -> type.toString()).collect(Collectors.joining(",
"))));
return null;
}
```
### Fix
Extract NetworkFilesystem/Filesystem/SharedMountPoint into a single
QEMU_IMG_MANAGED_POOL_TYPES constant and route SharedMountPoint through the
same qemu-img-based creation path as NFS/Filesystem everywhere that set is
consulted.
<!--- Describe your changes in DETAIL - And how has behaviour functionally
changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to
reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be
closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!---
*******************************************************************************
-->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE
DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!---
*******************************************************************************
-->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [x] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Tested the 3 failing test cases with and without the fix.
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to
-->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
