piyush5netapp commented on PR #13578: URL: https://github.com/apache/cloudstack/pull/13578#issuecomment-4950331265
> > @piyush5netapp > > I got two issues with the plugin > > > > * the unit tests are always run even if `-DskipTests` flag is passed. > > > > can you please remove `skiptTests` in pom.xml ? > > ``` > > # grep skipTests plugins/storage/volume/ontap/pom.xml > > <skipTests>false</skipTests> > > ``` > > > > > > > > > > > > > > > > > > > > > > > > > > * there are a lot of test failures when build the plugin with openjdk 21 > > > > ``` > > JAVA_HOME=/usr/lib/jvm/java-21-openjdk-amd64 mvn -T8 -P developer,systemvm clean install -Dnoredist -pl plugins/storage/volume/ontap/ > > ``` > > > > > > > > > > > > > > > > > > > > > > > > no issues when build with openjdk 17. > > could you please check ? the issue seems related to mockito versions which are too old. > > ``` > > <mockito.version>3.12.4</mockito.version> > > <mockito-junit-jupiter.version>5.2.0</mockito-junit-jupiter.version> > > ``` > > Hi @winterhazel Thankyou, will take care of `skipTests` being set to `false` in pom.xml. Quick question on Java 21 JDK. We've noticed that the 4.22 documentation recommends Java 17 [https://docs.cloudstack.apache.org/en/latest/upgrading/upgrade/_java_version.html]. So, was wondering, what's the recommended Java version for v4.23 and above? Tagging @weizhouapache as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
