weizhouapache commented on PR #13578: URL: https://github.com/apache/cloudstack/pull/13578#issuecomment-4950625430
> > > > > > > > no issues when build with openjdk 17. > > could you please check ? the issue seems related to mockito versions which are too old. > > ``` > > <mockito.version>3.12.4</mockito.version> > > <mockito-junit-jupiter.version>5.2.0</mockito-junit-jupiter.version> > > ``` > > Hi @winterhazel Thankyou, will take care of `skipTests` being set to `false` in pom.xml. Quick question on Java 21 JDK. We've noticed that the 4.22 documentation recommends Java 17 [https://docs.cloudstack.apache.org/en/latest/upgrading/upgrade/_java_version.html]. So, was wondering, what's the recommended Java version for v4.23 and above? @sandeeplocharla Java 17 is the recommended version, although Java 21 is also supported as a runtime. At the moment, building with Java 21 is broken due to test failures in the NetApp plugin. If possible, please use the Mockito version defined in the pom.xml: ``` <cs.mockito.version>5.16.1</cs.mockito.version> ``` Could you please fix these two issues as soon as possible in a separated PR ? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
