Copilot commented on code in PR #13609:
URL: https://github.com/apache/cloudstack/pull/13609#discussion_r3577245118
##########
plugins/storage/volume/ontap/pom.xml:
##########
@@ -163,7 +163,6 @@
<artifactId>maven-surefire-plugin</artifactId>
<version>${maven-surefire-plugin.version}</version>
<configuration>
- <skipTests>false</skipTests>
<includes>
<include>**/*Test.java</include>
</includes>
Review Comment:
With the hardcoded `<skipTests>false</skipTests>` removed, this module will
now honor `-DskipTests`, which is good. However, if the intent is to also
support skipping test *execution* while still compiling tests (Maven’s
`-DskipTests` behavior differs from `-Dmaven.test.skip=true`), consider
documenting in this module (or parent build docs) which flag users should use
for Java 21 incompatibilities (`-DskipTests` vs `-Dmaven.test.skip=true`) to
avoid confusion and inconsistent builds across modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
