DaanHoogland commented on code in PR #13588:
URL: https://github.com/apache/cloudstack/pull/13588#discussion_r3612834601
##########
server/src/main/java/org/apache/cloudstack/ha/HAManagerImpl.java:
##########
@@ -221,13 +221,16 @@ private HAResource validateAndFindHAResource(final
HAConfig haConfig) {
return resource;
}
- private HAProvider<HAResource> validateAndFindHAProvider(final HAConfig
haConfig, final HAResource resource) {
+ HAProvider<HAResource> validateAndFindHAProvider(final HAConfig haConfig,
final HAResource resource) {
if (haConfig == null) {
return null;
}
final HAProvider<HAResource> haProvider =
haProviderMap.get(haConfig.getHaProvider());
if (haProvider != null && !haProvider.isEligible(resource)) {
- if (haConfig.getState() != HAConfig.HAState.Ineligible) {
+ // A fenced host is expected to be ineligible as fencing puts it
in maintenance mode;
+ // it must remain Fenced until a health check passes (Fenced ->
HealthCheckPassed -> Ineligible),
+ // so there is no Fenced -> Ineligible transition to attempt here.
Review Comment:
can this comment be moved to javadoc? it seems a bit excessive here in the
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
