Damans227 commented on code in PR #13647:
URL: https://github.com/apache/cloudstack/pull/13647#discussion_r3624820440
##########
ui/src/components/view/ListView.vue:
##########
@@ -655,8 +655,7 @@
<template v-if="column.key === 'usageType'">
{{ usageTypeMap[record.usagetype] }}
</template>
-
- <template v-if="column.key === 'clustername'">
+<template v-if="column.key === 'clustername'">
Review Comment:
Nit: this line lost its indentation, looks like an accidental de-indent
(surrounding `<template>` blocks are indented 6 spaces).
##########
ui/src/components/view/ActionButton.vue:
##########
@@ -177,6 +177,15 @@ export default {
methods: {
execAction (action) {
action.resource = this.resource
+ const record = this.resource || this.item
+ if (action?.api === 'disableOutOfBandManagementForHost' &&
(record?.hostha?.haenable === true || record?.hastate === 'Enabled')) {
+ this.$notification.error({
+ message: this.$t('label.error'),
+ description: 'Please disable High Availability (HA) on this host
before disabling Out-of-Band Management (OOBM).',
Review Comment:
Nit: hardcoded English string here instead of `$t()`, rest of the UI runs
user-facing messages through i18n.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
