winterhazel commented on PR #13658:
URL: https://github.com/apache/cloudstack/pull/13658#issuecomment-5040113245

   @DaanHoogland and @GaOrtiga 
   
   > @winterhazel , would it make sense to have the quota summary page not show 
the project toggle instead?
   
   The project toggle is not shown in the Quota summary page. What happens is 
that toggling it in other pages and then switching to Quota summary makes the 
UI send `projectid=-1` to the `quotaSummary` API.
   
   > Also, unknown parameters should be gracefully ignored in the API layer, 
can you show the logging for the call?
   
   The API returns a `Unable to find project with the specified ID` because it 
tries to find a project with ID -1, as there is no special handling for 
`projectid=-1`.
   
   >  @winterhazel is there a reason to not add the handling directly on the 
API?
   
   Ever since the API was introduced, it already returns entries for the 
accessible projects by default. We did not add this handling in #10505 because 
there was no reason to, as the default response was not changed.
   
   ---
   
   Btw, I am fine with both approaches. I will submit a new commit that turns 
providing `projectid=-1` into a null operation. Please let me know which one 
you all prefer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to