Re: [PR] Don't set compressionstatus and validation status in backupVO and bac… [cloudstack]

Wed, 22 Jul 2026 07:31:10 -0700 


JoaoJandre commented on PR #13661:
URL: https://github.com/apache/cloudstack/pull/13661#issuecomment-5047461506

   > > > @abh1sar @JoaoJandre I think hiding these two columns when not using 
the KBOSS plugin is ok. A single suggestion: when using KBOSS, isn't it better 
to display `Unknown` in these columns for backups created using other 
providers, instead of an empty column with a gray circle? The way these are 
shown now may look like a bug.
   > > 
   > > 
   > > Made the change. It appears like this now: <img alt="Screenshot 
2026-07-22 at 11 07 48 AM" width="1663" height="1013" 
src="https://private-user-images.githubusercontent.com/63767682/624906989-3b0472a0-37ad-410b-960c-8071a81e96a5.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODQ3Mjc3OTEsIm5iZiI6MTc4NDcyNzQ5MSwicGF0aCI6Ii82Mzc2NzY4Mi82MjQ5MDY5ODktM2IwNDcyYTAtMzdhZC00MTBiLTk2MGMtODA3MWE4MWU5NmE1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjA3MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwNzIyVDEzMzgxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ5YTI1YjM4OTkwNGJhNWRlZTc3ZmM2NzBmZThmNWFlODE5YzczZGVkNjM2MTRiMTIxZmUyMjA0ZDBhODRkZDkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.ZUP7oyUZa6w9nzoiRvG0XI_Fpl9xOizk4OLk7Ao3q_A";>
   > 
   > @abh1sar thank you. The code looks good to me. I will also do some basic 
testing.
   > 
   > @JoaoJandre are you ok with these changes?
   
   @winterhazel I think it is fine. Although I will not have time to review or 
test this today, from the description and screenshots it seems ok.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to