winterhazel commented on code in PR #13680:
URL: https://github.com/apache/cloudstack/pull/13680#discussion_r3641432817
##########
plugins/backup/kboss/src/main/java/org/apache/cloudstack/backup/KbossBackupProvider.java:
##########
@@ -1274,9 +1244,9 @@ protected void endBackupChainIfConfigured(BackupVO
backupVO) {
// Get updated record
InternalBackupJoinVO backupJoinVO =
internalBackupJoinDao.findById(backupVO.getId());
if (backupJoinVO.getCurrent() || (!backupChildren.isEmpty() &&
backupChildren.get(backupChildren.size() - 1).getCurrent())) {
- logger.info("As [{}] is true, we are ending the backup chain of
schedule [{}] for VM [{}]. The next backup will be a full backup.",
- backupVO.getBackupScheduleId(),
BackupValidationServiceJobController.backupValidationEndChainOnFail.toString());
- endBackupChain(userVmDao.findById(backupVO.getVmId()),
backupVO.getBackupScheduleId());
+ logger.info("As [{}] is true, we are ending the backup chain for
VM [{}]. The next backup will be a full backup.",
+
BackupValidationServiceJobController.backupValidationEndChainOnFail.toString());
Review Comment:
Should we also add a `validateVmState(vm, "end backup chain",
VirtualMachine.State.Expunging, VirtualMachine.State.Destroyed);` here to
prevent a validation failure from finishing chains of VMs that are migrating,
for instance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
