dheeraj12347 commented on code in PR #13543:
URL: https://github.com/apache/cloudstack/pull/13543#discussion_r3659572937
##########
plugins/api/discovery/src/main/java/org/apache/cloudstack/discovery/ApiDiscoveryServiceImpl.java:
##########
@@ -236,10 +237,19 @@ protected ApiDiscoveryResponse getCmdRequestMap(Class<?>
cmdClass, APICommand ap
paramResponse.setSince(parameterAnnotation.since());
}
paramResponse.setRelated(parameterAnnotation.entityType()[0].getName());
- if (parameterAnnotation.authorized() != null) {
-
paramResponse.setAuthorizedRoleTypes(Arrays.asList(parameterAnnotation.authorized()));
- }
- response.addParam(paramResponse);
+
+ String[] allowedValues = parameterAnnotation.allowedValues();
Review Comment:
> Nit: this new block is indented 4 spaces less than the surrounding code
(`paramResponse.setRelated(...)` above and the closing brace below are both at
the deeper indent), looks like a stray de-indent.
Thanks for the review! I've fixed the indentation to match the surrounding
code. Please let me know if there are any other changes you'd like me to make.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
