dheeraj12347 commented on PR #13543: URL: https://github.com/apache/cloudstack/pull/13543#issuecomment-5121156070
Hi @Pearl1594 and @soreana, I've addressed the review comments: Updated the internet protocol values to match the canonical enum names where applicable. Fixed the indentation issue in ApiDiscoveryServiceImpl. Verified the updated tests locally. I've now marked this PR as Ready for Review. I'd appreciate any further feedback when you have time. As outlined in my GSoC proposal, the next phase (PR4) builds on the allowedValues support introduced in this PR by annotating the remaining API parameters and adding the planned lint/check. Since that work depends on the functionality introduced here, I'd prefer to wait for this PR to be reviewed and merged first so that the follow-up changes are based on main and remain easier to review. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
