Damans227 opened a new pull request, #13788: URL: https://github.com/apache/cloudstack/pull/13788
### Description If one listener in `handleCommands` throws, the whole loop stops and every listener after it never runs. This can starve `pingBy()` and cause fake ping timeouts. This wraps each listener call in a try/catch, so one bad listener just logs a warning and the rest still run. Also fixed a trace log nearby that was logging the wrong class (the `Pair` wrapper instead of the listener). Also added the missing `hostId` field to `IdsPowerStateSelectSearch`. Without it, VMs loaded through that path always showed a null host, even when they had one. Not a crash, just a wrong log message. ### Types of changes - [x] Bug fix ### Feature/Enhancement Scale or Bug Severity #### Bug Severity - [x] Major ### How Has This Been Tested? Added tests: a throwing listener doesn't block the next one, and existing behavior with only successful listeners is unchanged. Also added tests for the null-hostId case, which had no coverage before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
