Copilot commented on code in PR #13812: URL: https://github.com/apache/cloudstack/pull/13812#discussion_r3727825289
########## tools/build/build_asf.sh: ########## @@ -103,6 +103,9 @@ perl -pi -e "s/-SNAPSHOT//" tools/marvin/marvin/deployAndRun.py perl -pi -e "s/-SNAPSHOT//" tools/docker/Dockerfile perl -pi -e "s/-SNAPSHOT//" tools/docker/Dockerfile.marvin perl -pi -e "s/-SNAPSHOT//" tools/docker/Dockerfile.centos6 +perl -pi -e "s/-SNAPSHOT//" tools/docker/Dockerfile.s390x +perl -pi -e "s/-SNAPSHOT//" plugins/hypervisors/ovm/pom.xml +perl -pi -e "s/-SNAPSHOT//" plugins/hypervisors/ovm3/pom.xml Review Comment: This block has grown into many near-identical `perl -pi -e 's/-SNAPSHOT//' ...` lines. It’s easy to miss files when new Dockerfiles/modules are added (as happened here), and it makes future updates more error-prone. Consider collapsing these into a simple loop over a file list to reduce duplication and simplify maintenance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
