DaanHoogland commented on code in PR #13058:
URL: https://github.com/apache/cloudstack/pull/13058#discussion_r3765769893


##########
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVNCHandler.java:
##########
@@ -183,12 +190,20 @@ public void onClose(Session session, int statusCode, 
String reason) throws IOExc
 
     @OnWebSocketFrame
     public void onFrame(Frame f) throws IOException {
+        if (viewer == null) {
+            logger.debug("Ignoring WebSocket frame because viewer is not 
initialized yet.");
+            return;
+        }
         logger.trace("Sending client [ID: {}] frame of {} bytes.", 
viewer.getClientId(), f.getPayloadLength());

Review Comment:
   ```suggestion
           logger.trace("Sending client [ID: {}] frame of {} bytes.", 
viewer.getClientId(), f.getPayloadLength());
           viewer.updateFrontEndActivityTime();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to