DaanHoogland commented on issue #13893:
URL: https://github.com/apache/cloudstack/issues/13893#issuecomment-5314542393
Another variant found while writing wiring tests for
`ApiRateLimitServiceImpl`
(`plugins/api/rate-limit/src/main/java/org/apache/cloudstack/ratelimit/ApiRateLimitServiceImpl.java:79-113`):
the read site was never migrated to `.value()` at all (still raw
`_configDao.getValue(key.key())`, tracked separately under #13898), and its own
fallback shape is `if (raw != null) { field = parse(raw); }` — i.e. the class
keeps its own hardcoded Java field default whenever the config row is missing,
rather than ever consulting the ConfigKey's registered default. Two concrete
divergences:
- `maxAllowed` field defaults to `30`; `ManagementServer.ApiLimitMax`'s
registered default is `"25"`.
- `maxElements` (ehcache size) defaults to `10000`;
`ApiRateLimitService.ApiLimitCacheSize`'s registered default is `"50000"`.
This one was actually already known/deliberately deferred earlier in the
#10752 `.value()`-replacement pass, specifically because `ApiRateLimitTest`
mocks `ApiLimitEnabled="true"` (opposite of the registered `"false"" default)
purely so its functional tests have rate limiting turned on — flagging the two
numeric ones here since they hadn't been written down anywhere yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
