DaanHoogland commented on issue #13898: URL: https://github.com/apache/cloudstack/issues/13898#issuecomment-5314992812
A third variant, found while writing wiring tests for `ApiRateLimitServiceImpl`: `plugins/api/rate-limit/src/main/java/org/apache/cloudstack/ratelimit/ApiRateLimitServiceImpl.java:84-99` reads `ManagementServer.ApiLimitEnabled`/`ApiLimitInterval`/`ApiLimitMax`/`ApiLimitCacheSize` via plain inline `_configDao.getValue(key.key())` — the exact call shape the original `.value()`-replacement survey was designed to catch, but this site was deliberately left un-migrated rather than missed. It was skipped earlier in the #10752 `.value()`-replacement pass because `ApiRateLimitTest` mocks `ApiLimitEnabled="true"`, the opposite of the registered `"false"` default, purely so its functional tests exercise rate limiting — converting to `.value()` would have silently flipped that test's assumed default. Distinct from the other two variants here (raw config-map literal lookup, and the two-step `.key()`-then-`getValue()` indirection) in that it's a simple, direct, already-known deferral rather than something the survey missed structurally — but it belongs in the same bucket since the underlying risk (raw retrieval never falling back to the registered ConfigKey default) is identical. See also the divergent-default numbers on #13893. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
