waterWang opened a new pull request, #13929:
URL: https://github.com/apache/cloudstack/pull/13929

   ### Fixes
   
   Fixes #13900
   
   ### Root cause
   
   `DownloadListener.getAccountIdForDataObject()` only handles `TEMPLATE` and 
`VOLUME` data object types. For `SNAPSHOT` data objects it falls through and 
returns `null`, so `checkAndUpdateResourceLimits()` calls 
`_accountMgr.getAccount(null)` — the account lookup fails, resource-limit 
accounting is skipped, the download is never marked successful, and 
`copySnapshot` between zones times out after ~90s even though the destination 
SSVM already finished downloading the snapshot files.
   
   ### Fix
   
   Add a `SNAPSHOT` branch to `getAccountIdForDataObject()` that looks up the 
snapshot's account via `SnapshotDao.findById()`, mirroring the existing 
`TEMPLATE`/`VOLUME` branches. The downloaded snapshot files are already present 
on the destination store; only the account attribution and resource-count 
update were missing.
   
   ### Testing
   
   - `mvn -pl server -am compile` passes
   - No new dependencies — `SnapshotDao` is already used elsewhere in the 
server module
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to