winterhazel opened a new pull request, #13946: URL: https://github.com/apache/cloudstack/pull/13946
### Description `allocateDnsZone` allows users to register DNS zones that conflict with DNS zones from the same server belonging to other users, which consequently allows them to shadow DNS records belonging to other users. **Example:** Victim tenant runs `tenant1.cloud.example` with www → 203.0.113.10 on a shared public server (suffix `cloud.example`). A co-tenant calls `createDnsZone name=www.tenant1.cloud.example dnsserverid=<shared>` — accepted as-is — then adds an apex A record to their own IP; every resolver using that PowerDNS now resolves the victim's hostname to the attacker. This patch rejects zones that overlap another tenant's zone as either a DNS parent or child, and also requires a non-blank `publicDomainSuffix` for public servers. It was mostly generated using AI tools, but reviewed and tested by a human. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Bug Severity - [X] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? I reproduced the example scenario before the patch, and verified that it is not reproducible anymore after the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
