sureshanaparti opened a new pull request, #13990:
URL: https://github.com/apache/cloudstack/pull/13990
### Description
The PR addresses the following issue:
During host connect process, management server chooses which storage pool to
connect to, using storage pool scope (CLUSTER or ZONE) and storage access group
(tags). In the scenario where configuration `mount.disabled.storage.pool` is
ON, the behaviour is different/buggy.
- Connect to storage pools in UP state which satisfy the storage access
group filter.
- Connect to all storage pools which are in DISABLED state - storage access
group filter is not applied here.
The above edge case with the below changes are handled when the config
`mount.disabled.storage.pool` is ON:
- Logic for connecting to storage pools in UP state is unchanged.
- Filter storage pools by Disabled State and Storage Access Groups before
connecting.
<!--- Describe your changes in DETAIL - And how has behaviour functionally
changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to
reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be
closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!---
*******************************************************************************
-->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE
DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!---
*******************************************************************************
-->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Scenarios:
1. **mount.disabled.storage.pool is OFF:**
- Same behaviour as before. Nothing has been changed.
2. **mount.disabled.storage.pool is ON and storage access group of host is
"group1":**
- The host would connect to all groups that it would have connected to if
config `mount.disabled.storage.pool` was OFF. Additionally, the host would
connect to all storage pools in Disabled state with the below filters:
- Storage pools with empty storage access groups OR
- Storage pools with "group1" storage access group.
3. **mount.disabled.storage.pool is ON and storage access group of host is
empty:**
- The host would connect to all groups that it would have connected to if
config `mount.disabled.storage.pool` was OFF. Additionally, the host would
connect to all storage pools in Disabled state with the below filters:
- Storage pools with empty storage access groups.
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to
-->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
