DaanHoogland commented on code in PR #14001:
URL: https://github.com/apache/cloudstack/pull/14001#discussion_r3879752920
##########
engine/orchestration/src/main/java/com/cloud/agent/manager/ClusteredAgentManagerImpl.java:
##########
@@ -1037,6 +1037,20 @@ protected boolean rebalanceHost(final long hostId, final
long currentOwnerId, fi
protected boolean rebalanceHost(final long hostId, final long
currentOwnerId, final long futureOwnerId, final boolean isConnectionTransfer)
throws AgentUnavailableException {
boolean result = true;
if (currentOwnerId == _nodeId) {
+ final AgentAttache attache = findAttache(hostId);
+ if (attache != null && !(attache instanceof
ClusteredDirectAgentAttache)) {
+ // Indirectly connected agents (KVM hosts, SSVM, CPVM) dial in
to a management server rather
+ // than being loaded directly by it, so this management server
can't hand the host to a
+ // specific future owner the way it can for direct agents.
Disconnect it instead: the agent
+ // reconnects on its own using its indirect agent LB
configuration (the "host" global setting
+ // and indirect.agent.lb.algorithm), which is what actually
determines its next owner.
Review Comment:
evaluate and redact comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
