JoaoJandre commented on issue #14030: URL: https://github.com/apache/cloudstack/issues/14030#issuecomment-5499186198
The VM disk-only VM snapshots are all or nothing in this sense, either all volumes have the same amount of deltas or there is something wrong. I believe that some process similar to what was done to KBOSS could be extended to the disk-only VM snapshot feature: have an API that will validate what ACS has in the database and try to synchronize with what is actually on storage. Maybe the VM should be put in an error state when the VM snapshot delete fails and not all volumes have the same amount of deltas (such as in the example you gave). Then the user must call the API to delete the VM snapshot, and will ACS sync with what is actually on storage and finalize the VM snapshot deletion. Another way forward would be doing as you said and update only the volumes that succeeded, however, there are some cases where we are not sure if the volume merge succeeded or not, so I would be more inclined to have an API to sync and retry the process than to assume things are ok, as this would fix more cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
