Copilot commented on code in PR #14057:
URL: https://github.com/apache/cloudstack/pull/14057#discussion_r3931562036
##########
.asf.yaml:
##########
@@ -72,6 +72,16 @@ github:
restrict_deletion: true
restrict_force_push: true
+ required_pull_request_reviews:
+ required_approving_review_count: 2
+
+ required_status_checks:
+ - "Build / build"
+ - "pre-commit / Run pre-commit"
+ - "UI Build / build"
+ - "Simulator CI / build"
+ - "License Check / build"
Review Comment:
The required status checks include only "Simulator CI / build", but the
Simulator CI workflow also has a separate "test" job. Since the build job runs
Maven with -DskipTests=true, merges could be allowed even if the simulator test
job fails. Add "Simulator CI / test" to the required checks (or otherwise
ensure the test job is required).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
