dheeraj12347 commented on PR #12850: URL: https://github.com/apache/cloudstack/pull/12850#issuecomment-5566850827
Hi @DaanHoogland , I reviewed the Copilot comments and addressed all three. - The existence checks now use check_output() directly, so expected return code 1 does not go through execute() and produce an ERROR traceback. - ip6tables command-not-found (return code 127) is handled as a DEBUG/skip during cleanup. - ipset command-not-found (return code 127) is handled similarly. I also ran the Python syntax check and git diff --check locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
