shwstppr commented on code in PR #9692:
URL: https://github.com/apache/cloudstack/pull/9692#discussion_r3946702241
##########
api/src/main/java/org/apache/cloudstack/api/response/IPAddressResponse.java:
##########
@@ -143,6 +143,10 @@ public class IPAddressResponse extends
BaseResponseWithAnnotations implements Co
@Param(description = "Purpose of the IP address. In Acton this value is
not null for IPs with isSystem=true, and can have either StaticNat or LB value")
private String purpose;
+ @SerializedName(ApiConstants.VPC_ACCESS)
+ @Param(description = "Whether the calling account has access to this
network's VPC", since = "4.21.0")
Review Comment:
```suggestion
@Param(description = "Whether the calling account has access to this
network's VPC", since = "4.24.0")
```
##########
api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java:
##########
@@ -203,6 +203,10 @@ public class NetworkResponse extends
BaseResponseWithAssociatedNetwork implement
@Param(description = "True if Network supports specifying IP ranges, false
otherwise")
private Boolean specifyIpRanges;
+ @SerializedName(ApiConstants.VPC_ACCESS)
+ @Param(description = "Whether the calling account has access to this
network's VPC", since = "4.21.0")
Review Comment:
```suggestion
@Param(description = "Whether the calling account has access to this
network's VPC", since = "4.23.0")
```
##########
api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java:
##########
@@ -203,6 +203,10 @@ public class NetworkResponse extends
BaseResponseWithAssociatedNetwork implement
@Param(description = "True if Network supports specifying IP ranges, false
otherwise")
private Boolean specifyIpRanges;
+ @SerializedName(ApiConstants.VPC_ACCESS)
Review Comment:
Can we not get this information from network owner? I don't think these
response param is needed and UI can probably get these values at runtime based
on the caller and AI response data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
