nvazquez commented on code in PR #12409:
URL: https://github.com/apache/cloudstack/pull/12409#discussion_r3951946879
##########
framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java:
##########
@@ -1284,6 +1296,74 @@ private void
cleanupFailedSnapshotsCreatedWithDefaultStrategy(final long msid) {
}
}
+ /**
+ * Cleanup networks that are stuck in Implementing state without
associated async jobs.
+ * This only processes networks that have been stuck for longer than the
job expiration threshold.
+ */
+ private void cleanupOrphanedNetworks() {
+ try {
Review Comment:
Nice catch @winterhazel - can we keep it on this method and remove the
entire method `cleanupNetworksStuckInImplementing`? Then make the cleanup task
invoke this method directly (or rename it to
`cleanupNetworksStuckInImplementing`? cc @Pearl1594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
