sureshanaparti commented on code in PR #13589:
URL: https://github.com/apache/cloudstack/pull/13589#discussion_r3978349747
##########
plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/kvm/ha/KVMHAConfig.java:
##########
@@ -52,4 +52,11 @@ public interface KVMHAConfig {
ConfigKey<Long> KvmHAFenceTimeout = new ConfigKey<>("Advanced",
Long.class, "kvm.ha.fence.timeout", "60",
"The maximum length of time, in seconds, expected for a fence
operation to complete.", true, ConfigKey.Scope.Cluster);
+
+ ConfigKey<Boolean> KvmHAFenceOnStorageHeartbeat = new
ConfigKey<>("Advanced", Boolean.class, "kvm.ha.fence.on.storage.heartbeat",
"false",
Review Comment:
```suggestion
ConfigKey<Boolean> KvmHAFenceOOBMFallbackOnStorageHeartbeat = new
ConfigKey<>("Advanced", Boolean.class,
"kvm.ha.fence.oobm.fallback.on.storage.heartbeat", "false",
```
the new config is similar to the earlier config
'kvm.ha.fence.host.if.heartbeat.fails.on.storage' and can confuse the operator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
