sureshanaparti commented on code in PR #13589:
URL: https://github.com/apache/cloudstack/pull/13589#discussion_r3978360273


##########
plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/kvm/ha/KVMHAConfig.java:
##########
@@ -52,4 +52,11 @@ public interface KVMHAConfig {
 
     ConfigKey<Long> KvmHAFenceTimeout = new ConfigKey<>("Advanced", 
Long.class, "kvm.ha.fence.timeout", "60",
             "The maximum length of time, in seconds, expected for a fence 
operation to complete.", true, ConfigKey.Scope.Cluster);
+
+    ConfigKey<Boolean> KvmHAFenceOnStorageHeartbeat = new 
ConfigKey<>("Advanced", Boolean.class, "kvm.ha.fence.on.storage.heartbeat", 
"false",

Review Comment:
   also, can we remove this config, and keep this as default behavior (and 
update the necessary docs).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to