nagaboinaramgopal commented on PR #13793: URL: https://github.com/apache/cloudstack/pull/13793#issuecomment-5639843737
@Dogface2k @abh1sar I have tested this on Debian 13 (setuptools 78.1.1, Python 3.13), with the change applied to the 4.22 branch. Without this PR, `dpkg-buildpackage` stops at `cp tools/marvin/dist/Marvin-*.tar.gz` because setuptools writes `marvin-4.22.2.0.tar.gz`. With this PR the build completes and cloudstack-marvin contains `/usr/share/cloudstack-marvin/marvin-4.22.2.0.tar.gz`. The postinst glob picks it up: `pip install --upgrade /usr/share/cloudstack-marvin/[Mm]arvin-*.tar.gz` processes the file and builds Marvin. Two things I saw while installing the package on Debian 13. They are not caused by this PR: - The first postinst line, `python3 -m pip install --upgrade pip`, fails with externally-managed-environment (PEP 668). With `PIP_BREAK_SYSTEM_PACKAGES=1` it still fails because pip cannot uninstall the Debian pip (`uninstall-no-record-file`). Debian 12 behaves the same way. - On 4.22, the PyCrypt dependency does not build on Python 3.13. main already uses pycryptodome (#13594). LGTM for the file name change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
