Copilot commented on code in PR #14033:
URL: https://github.com/apache/cloudstack/pull/14033#discussion_r4024492053
##########
utils/src/main/java/com/cloud/utils/nicira/nvp/plugin/NiciraNvpApiVersion.java:
##########
@@ -37,7 +37,7 @@ public static synchronized boolean
isApiVersionLowerThan(String apiVersion){
if (niciraApiVersion == null) {
return false;
}
- int compare = CloudStackVersion.compare(niciraApiVersion, apiVersion);
+ int compare = CloudStackVersion.compare(niciraApiVersion, apiVersion,
true);
Review Comment:
The callers of this method pass two-component thresholds such as `"4.2"`
(the VMware helper call sites), but `CloudStackVersion.parse(..., true)` still
requires 3 or 4 components. Consequently this updated call still throws before
comparing any Nicira/NSX API version, so the external-aware overload does not
make this path functional. Normalize the API-version inputs or use a comparator
that accepts the two-component external API format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
