shwstppr commented on code in PR #14033:
URL: https://github.com/apache/cloudstack/pull/14033#discussion_r4025000805
##########
utils/src/main/java/com/cloud/utils/nicira/nvp/plugin/NiciraNvpApiVersion.java:
##########
@@ -37,7 +37,7 @@ public static synchronized boolean
isApiVersionLowerThan(String apiVersion){
if (niciraApiVersion == null) {
return false;
}
- int compare = CloudStackVersion.compare(niciraApiVersion, apiVersion);
+ int compare = CloudStackVersion.compare(niciraApiVersion, apiVersion,
true);
Review Comment:
Not relevant as this API version comparison and 3-component version
requirement predates this PR's change.
Having `external` flag would allow comparison to work as it worked before
this PR.
Also, `isApiVersionLowerThan` is called in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
