nagaboinaramgopal commented on PR #14205: URL: https://github.com/apache/cloudstack/pull/14205#issuecomment-5732232092
This is the generic OIDC provider from the discussion on #13854: one `oidc` type that serves any number of registrations under admin-chosen names, with discovery and full id_token validation, so a new IdP no longer needs its own class. It overlaps #13499 (ForgeRock), which @bddvlpr put on hold in favour of doing the generic feature. My `GenericOIDCOAuth2Provider` is separate from the `AbstractOIDCOAuth2Provider` there, but three files touch the same code: `RegisterOAuthProviderCmd`, `spring-oauth2-context.xml` and `Login.vue`. Whichever lands second is a small rebase and I am happy for that to be mine. @bddvlpr @Damans227 this builds on your design, so please review. If you would rather fold the ForgeRock case in here as an `oidc` registration, or keep it as a named provider on top, either works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
