weizhouapache commented on code in PR #14247:
URL: https://github.com/apache/cloudstack/pull/14247#discussion_r4183195153
##########
plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java:
##########
@@ -582,4 +585,71 @@ public void testTpmModel() {
"<backend type='emulator' version='2.0'/>\n" +
"</tpm>\n", tpmDef.toString());
}
+
+ @Test
+ public void testDiskDefVirtioBlkUsesVirtioBusAndVdLabel() {
+ DiskDef disk = new DiskDef();
+ disk.defFileBasedDisk("/var/lib/libvirt/images/disk.qcow2", 1,
DiskDef.DiskBus.VIRTIOBLK, DiskDef.DiskFmtType.QCOW2);
Review Comment:
why you use virto-blk for a qcow2 file ?
virtio-blk indicates the volume is storaged on block storage, right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
