calvix commented on PR #14247:
URL: https://github.com/apache/cloudstack/pull/14247#issuecomment-6140186406
> I have some concerns about honoring "virtio-blk" as a separate disk
controller option.
>
> In libvirt, "virtio" is the disk bus, and the corresponding device is
already a VirtIO block device ("virtio-blk"). This is similar to how a VirtIO
NIC is represented by a "virtio" interface model, corresponding to a
"virtio-net" device.
>
> As a result, the existing CloudStack "virtio" disk controller option
already maps to a VirtIO block device. With this change, "virtio" and
"virtio-blk" would effectively expose the same device model, with the main
difference being that "virtio-blk" enables "discard='unmap'".
>
> I think this could be confusing for users, because the controller option
appears to describe the device type, while it also implicitly controls discard
behavior.
>
> Could we instead keep "virtio" as the controller option and handle
discard/unmap as a separate configuration? This would make the distinction
between the disk device model and its discard capability clearer.
Alright, I will take a look at how complicated it would be. I assume you
would also want to get rid of `virtio-blk` option completely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
