Damans227 commented on code in PR #14314:
URL: https://github.com/apache/cloudstack/pull/14314#discussion_r4188850228
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -1127,6 +1127,11 @@ private VolumeVO createVolumeOnStoragePool(Long
volumeId, Long storageId) throws
throw new InvalidParameterValueException(String.format("Disk
offering: %s is not compatible with the storage pool", diskOffering.getUuid()));
}
+ if (!storageMgr.storagePoolHasEnoughSpace(volume.getSize(),
storagePool)) {
Review Comment:
should this also check how full the pool really is on disk? the other space
checks look at that too, but this one only counts space already handed out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
