Copilot commented on code in PR #687: URL: https://github.com/apache/cloudstack-documentation/pull/687#discussion_r4191467881
########## source/adminguide/service_offerings.rst: ########## @@ -767,6 +784,105 @@ while egress traffic will be limited to 200 Mbps. In an isolated network, ingress traffic will be limited to 10 Mbps and egress to 200 Mbps. +.. note:: + Since 24.0, the network rate of the network offering no longer applies + to the NICs of a user instance; the compute offering rate (or + vm.network.throttling.rate) does. The network offering rate still Review Comment: The VMware explanation at lines 767–770 still says an unset compute-offering rate falls back to the network offering. This contradicts the new rule here and tells operators to configure the wrong setting for instance egress. Update that fallback to `vm.network.throttling.rate`. ########## source/adminguide/service_offerings.rst: ########## @@ -687,14 +689,20 @@ configured on the following: - Network Offering -- Service Offering +- Service Offering (the compute offering of an instance, and the + system offering of a virtual router) Review Comment: This bullet now includes the router's system offering, but the following paragraph says an unset service-offering rate falls back to `vm.network.throttling.rate`. That fallback applies to user instances, not router guest interfaces. Router guest interfaces use the system offering, then the guest network offering, then `network.throttling.rate`. Distinguish these cases so administrators do not configure the wrong global parameter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
