jmsperu commented on PR #12900: URL: https://github.com/apache/cloudstack/pull/12900#issuecomment-6019007483
@Pearl1594 thank you for testing this on a real setup; both problems were real. Fixed in 1b35a7be70: - Encrypted DB password: credentials now come from `DbProperties.getDbProperties()` (details in the thread). - Backup location ownership: when the directory cannot be created, the log now says "Failed to create infrastructure backup directory <dir>. The management server runs as user 'cloud', which needs write access to <location> (nas.infra.backup.location); for example, run 'chown cloud <location>' on the management server after mounting the NAS there. Also check that the NAS is mounted at that path." The user name is taken from the running process, not hard-coded. The `nas.infra.backup.location` description now states that the path must be writable by the management server user, and gives the per-server layout. Local results: InfrastructureBackupTaskTest 17/17, NASBackupProviderTest 21/21, checkstyle clean. Agreed on the documentation. I have prepared a section for the NAS plugin page in cloudstack-documentation (settings, on-NAS layout, the `cloud` user's write permission with a mount and chown example, and the opt-in database dump) and will open that PR shortly and link it here. On the failing `triage` check: that is the "PR Merge Conflict Check" workflow. Its log ends with `error removing "status:has-conflicts": HttpError: Resource not accessible by integration`, i.e. its token cannot edit labels when the run comes from a fork. It is not related to the change, and the branch has no conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
