danivogel90 commented on issue #14326:
URL: https://github.com/apache/cloudstack/issues/14326#issuecomment-6035351383
Thanks @weizhouapache! I verified the fix and opened PR #14331 against 4.22.
While testing I found two more things, both fixed in the PR:
1. Relaxing only the `mountpoint -q` check (as suggested in the description
above) is
**dangerous**: the later `/proc/mounts` check would then call
`deleteVMs`, which
`kill -9`s all VMs on the pool, on every heartbeat write. The PR uses the
same
check in both places.
2. `check_hbLog` reports a live host as DEAD if the heartbeat is read in the
same
second it was written (`expr` exits 1 when the result is 0).
Tested with script tests, live in the agent and with an HA failover test
(host hard-reset,
HA VM restarted on another host after ~110 s). Details are in the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
