nagaboinaramgopal commented on code in PR #14106:
URL: https://github.com/apache/cloudstack/pull/14106#discussion_r4211267473
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -1616,6 +1617,9 @@ private SetMonitorServiceCommand
createMonitorServiceCommand(DomainRouterVO rout
excludedTests = excludedTests.isEmpty() ?
BACKUP_ROUTER_EXCLUDED_TESTS : excludedTests + "," +
BACKUP_ROUTER_EXCLUDED_TESTS;
}
}
+ if (router.getRole() == Role.INTERNAL_LB_VM) {
Review Comment:
Thanks for checking. They don't stay until recreation, they get cleared on
the normal health check cycle. `getFailingChecks` (run by
`FetchRouterHealthChecksResultTask` on a fixed interval) calls
`resetRouterHealthChecksAndConnectivity` first, which expunges all stored
results for the router, and then re-persists only the checks the agent reported
that round (L1199-1200). Once the excluded-tests config reaches the internal LB
VM the agent stops reporting dhcp and dns, so on the next fetch the old failed
rows are expunged and not re-added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
