Damans227 commented on code in PR #14106:
URL: https://github.com/apache/cloudstack/pull/14106#discussion_r4211047842


##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -1616,6 +1617,9 @@ private SetMonitorServiceCommand 
createMonitorServiceCommand(DomainRouterVO rout
                 excludedTests = excludedTests.isEmpty() ? 
BACKUP_ROUTER_EXCLUDED_TESTS : excludedTests + "," + 
BACKUP_ROUTER_EXCLUDED_TESTS;
             }
         }
+        if (router.getRole() == Role.INTERNAL_LB_VM) {

Review Comment:
   what happens to the old failed dhcp and dns results on internal lb vms that 
already exist? looks like nothing updates them anymore so they might stay 
failed until the vm is recreated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to