sudo87 commented on code in PR #13325:
URL: https://github.com/apache/cloudstack/pull/13325#discussion_r4215699779
##########
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##########
@@ -3604,6 +3604,8 @@ public void
doInTransactionWithoutResult(TransactionStatus status) {
UsageEventUtils.publishUsageEvent(EventTypes.EVENT_NETWORK_OFFERING_ASSIGN,
vm.getAccountId(), vm.getDataCenterId(), vm.getId(), nicIdString,
networkOfferingId,
null, isDefault,
VirtualMachine.class.getName(), vm.getUuid(), vm.isDisplay());
}
+ Integer rate =
_configMgr.getNetworkOfferingNetworkRate(networkOfferingId,
network.getDataCenterId());
+ _networkDetailsDao.addDetail(networkId,
ApiConstants.NETWORKRATE, String.valueOf(rate), true);
Review Comment:
That's on purpose. A NIC's rate only takes effect when the VM or router is
next prepared, so updating nics.network_rate now would show a rate the running
VM isn't using yet. NICs pick up the new rate on the next start or restart with
cleanup, and this is covered in docs PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
