DaanHoogland opened a new pull request, #14370: URL: https://github.com/apache/cloudstack/pull/14370
### Description This PR... fixes an issue reported by claude code during extension development It fixes `updateExtension` refusing to remove a service from a NetworkOrchestrator extension's `network.services` detail after the only offering using it has been deleted. `deleteNetworkOffering` (and VPC offering deletion) only marks the offering as removed; its rows in `ntwk_offering_service_map` / `vpc_offering_service_map` remain. The in-use check in `ExtensionsManagerImpl.updateNetworkExtensionServicesOnPhysicalNetworks` looked only at those map rows, so it kept failing with: ``` Cannot remove service CustomAction from extension '<name>' as it is used by a network/VPC offering ``` The check now resolves each mapped offering ID through `NetworkOfferingDao` / `VpcOfferingDao` and only counts offerings that are not removed. updateExtension refused to drop a service from a NetworkOrchestrator extension's network.services detail if any ntwk_offering_service_map or vpc_offering_service_map row referenced it for the extension provider. Deleting an offering only sets its removed date and keeps those map rows, so a service stayed "in use" forever once any offering had used it. Only count offerings that still exist (findById excludes removed rows) when checking whether a service can be removed. Co-Authored-By: Claude Opus 5.5 <[email protected]> <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> #### How did you try to break this feature and the system with this change? <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
