Copilot commented on code in PR #13281:
URL: https://github.com/apache/cloudstack/pull/13281#discussion_r4221758622
##########
python/lib/cloudutils/serviceConfig.py:
##########
@@ -652,7 +583,6 @@ def config(self):
filename = "/etc/libvirt/qemu.conf"
cfo = configFileOps(filename, self)
- cfo.addEntry("security_driver", "\"none\"")
cfo.addEntry("user", "\"root\"")
cfo.addEntry("group", "\"root\"")
cfo.addEntry("vnc_listen", "\"0.0.0.0\"")
Review Comment:
With `security_driver=\"none\"` no longer being written, hosts that were
previously configured by older versions may still retain an existing
`security_driver=\"none\"` line in `/etc/libvirt/qemu.conf`, so
upgrading/re-running setup won’t actually stop enforcing that prior choice. If
the intent is to stop forcing libvirt security settings going forward, consider
explicitly removing an existing `security_driver` entry when present (or
introducing an explicit migration/flag) so existing installations move back to
the distro/operator default without requiring manual cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
