Damans227 commented on code in PR #14364:
URL: https://github.com/apache/cloudstack/pull/14364#discussion_r4231469881
##########
systemvm/debian/opt/cloud/bin/configure.py:
##########
@@ -632,7 +632,9 @@ def init_vpc(self, direction, acl, rule, config):
self.dport = ""
if 'allowed' in list(rule.keys()) and rule['allowed']:
self.action = "ACCEPT"
- if 'first_port' in list(rule.keys()):
+ # A tcp or udp rule without ports is sent with the range 0:0;
like the nft paths, match all ports
+ no_ports = rule.get('first_port', 0) == 0 and
rule.get('last_port', 0) == 0
Review Comment:
should the api refuse a tcp or udp rule with port 0 alone now? with this a
deny on port 0 quietly becomes a deny on every port
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
