Damans227 commented on code in PR #14364:
URL: https://github.com/apache/cloudstack/pull/14364#discussion_r4273609233
##########
systemvm/debian/opt/cloud/bin/configure.py:
##########
@@ -632,7 +632,9 @@ def init_vpc(self, direction, acl, rule, config):
self.dport = ""
if 'allowed' in list(rule.keys()) and rule['allowed']:
self.action = "ACCEPT"
- if 'first_port' in list(rule.keys()):
+ # A tcp or udp rule without ports is sent with the range 0:0;
like the nft paths, match all ports
+ no_ports = rule.get('first_port', 0) == 0 and
rule.get('last_port', 0) == 0
Review Comment:
the 0:0 check in 20e1dc4b17 covers it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
