Damans227 commented on code in PR #14136:
URL: https://github.com/apache/cloudstack/pull/14136#discussion_r4233530651
##########
server/src/main/java/com/cloud/hypervisor/HypervisorGuruBase.java:
##########
@@ -332,6 +364,8 @@ protected VirtualMachineTO
toVirtualMachineTO(VirtualMachineProfile vmProfile) {
addExtraConfig(detailsInVm, to, vm.getAccountId(),
vm.getHypervisorType());
}
+ addDefaultNicQueuesForSystemVm(to);
Review Comment:
what happens when a new tier is added to a running vpc router? looks like
that new nic still gets one queue until the router restarts
##########
server/src/main/java/com/cloud/hypervisor/HypervisorGuruBase.java:
##########
@@ -265,6 +269,34 @@ protected void
addServiceOfferingExtraConfiguration(ServiceOffering offering, Vi
}
}
+ /**
+ * Gives a system VM one NIC queue per CPU. The guest only ever uses as
many queues as it has
+ * CPUs, so this is what the CPU count already implies, and a system VM is
only given more CPUs
+ * to move more packets.
+ *
+ * A user VM sets this per VM with deployVirtualMachine or
updateVirtualMachine. A system VM
+ * goes through neither, so there is otherwise no way for it to get a
queue at all.
+ *
+ * The default offering is a single CPU, so nothing changes until an
operator resizes.
+ */
+ protected void addDefaultNicQueuesForSystemVm(VirtualMachineTO to) {
Review Comment:
how does this fit with #14378, which lets admins set the router queue count
per offering? if both go in it looks like this one would override theirs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
