bernardodemarco commented on code in PR #14136:
URL: https://github.com/apache/cloudstack/pull/14136#discussion_r4234279219
##########
server/src/main/java/com/cloud/hypervisor/HypervisorGuruBase.java:
##########
@@ -265,6 +269,34 @@ protected void
addServiceOfferingExtraConfiguration(ServiceOffering offering, Vi
}
}
+ /**
+ * Gives a system VM one NIC queue per CPU. The guest only ever uses as
many queues as it has
+ * CPUs, so this is what the CPU count already implies, and a system VM is
only given more CPUs
+ * to move more packets.
+ *
+ * A user VM sets this per VM with deployVirtualMachine or
updateVirtualMachine. A system VM
+ * goes through neither, so there is otherwise no way for it to get a
queue at all.
+ *
+ * The default offering is a single CPU, so nothing changes until an
operator resizes.
+ */
+ protected void addDefaultNicQueuesForSystemVm(VirtualMachineTO to) {
Review Comment:
> only gap i see is the storage and console proxy vms
Yes. One alternative would be to keep this one for SSVMs and CPVMs and
https://github.com/apache/cloudstack/pull/14378 for VRs. I do not know what is
the use case to apply multi-queue for CPVMs and SSVMs, but it would be great to
have a setting to indicate whether the number of queues should always be equal
to the number of vCPUs. This behavior may not be always desired.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
